Fixes Accessibility issue: backwards tabbing required to access langu…#1133
Fixes Accessibility issue: backwards tabbing required to access langu…#1133demiankatz merged 2 commits intoUniversalViewer:devfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @LlGC-jop -- this solution seems reasonable (at least for the short term -- as you say, there may be better long-term approaches).
Just one observation: this PR includes a lot of changes that are unrelated to the actual fix at hand. Is it possible you have some IDE settings that are automatically changing the code? It might be good to undo some of these things so it's easier to see the intention of the commit.
jamesmisson
left a comment
jamesmisson
left a comment
There was a problem hiding this comment.
Code and Vercel reviewed. Looks good with Demian's changes, thanks Jonathan
LanieOkorodudu
left a comment
LanieOkorodudu
left a comment
There was a problem hiding this comment.
I tested this in Vercel app and looks good on my end too. Thanks again @LlGC-jop
|
@demiankatz I've committed a change to undo the auto-formatting. |
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @LanieOkorodudu and @LlGC-jop!
4 participants
…age settings #1071
Fixes #1071 by setting focus on the first select or input when the dialogue opens
I've not done anything to trap focus etc. as that's beyond the scope of this specific issue, and more involved than I think we have time for in the sprint.
A long-term solution would be to use a
<dialog>element as I think that covers the needed a11y requirements, but we can address that in a separate issue / future sprint.